Client middleware regression

[Phill Wolf]

In 0.4.1-beta-2, aleph.http.client-middleware's generate-query-string does
not work as well as it used to.

It needs two repairs:

First: the (if (sequential? v... has no "else" form and therefore causes
non-collection values to be omitted altogether, whereupon the StringBuffer
has length 0 and the substring throws StringIndexOutOfBoundsException.
Experiment suggests that the (if... is unnecessary. It encloses a p/doit
whose binding form also has a (sequential? test that wraps strings in a
vector and then processes the vector ok.

Second: the substring invocation uses the arity-1 version ("from the given
offset to the end"), but should use the arity-2 form (with 0 as the first
parameter) in order to keep everything but the last, unnecessary &
character.

[Zach Tellman]

Thank you for catching this. Can you open an issue on the repository?

Post by Phill Wolf
In 0.4.1-beta-2, aleph.http.client-middleware's generate-query-string
does not work as well as it used to.
First: the (if (sequential? v... has no "else" form and therefore causes
non-collection values to be omitted altogether, whereupon the StringBuffer
has length 0 and the substring throws StringIndexOutOfBoundsException.
Experiment suggests that the (if... is unnecessary. It encloses a p/doit
whose binding form also has a (sequential? test that wraps strings in a
vector and then processes the vector ok.
Second: the substring invocation uses the arity-1 version ("from the
given offset to the end"), but should use the arity-2 form (with 0 as the
first parameter) in order to keep everything but the last, unnecessary &
character.
--
You received this message because you are subscribed to the Google Groups "Aleph" group.
To unsubscribe from this group and stop receiving emails from it, send an
For more options, visit https://groups.google.com/d/optout.